debounce and improve config file watcher#587
Open
redneck-f25 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves automatic authfile reloading by watching the containing directory, debouncing filesystem events, and normalizing paths for matching.
Changes:
- Watches the authfile parent directory instead of the file itself.
- Adds path normalization and Windows case-insensitive path comparison.
- Debounces write/create/rename events before reloading users.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
793a777 to
705d631
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your great work on chisel.
In my use case i often have to edit the authfile and the automatic reloading works almost always.
In this PR I added debouncing for fsnotify events, path normalization and case handling for Windows.
Somtimes, editors or update jobs do nasty things, which leads to multiple writes or renames.
touch .users.json~ # new config cp -a users.config .users.config- mv .users.config~ users.config rm .users.config-