Skip to content

debounce and improve config file watcher#587

Open
redneck-f25 wants to merge 2 commits into
jpillora:masterfrom
redneck-f25:improve-config-file-watcher
Open

debounce and improve config file watcher#587
redneck-f25 wants to merge 2 commits into
jpillora:masterfrom
redneck-f25:improve-config-file-watcher

Conversation

@redneck-f25
Copy link
Copy Markdown

Thanks for your great work on chisel.

In my use case i often have to edit the authfile and the automatic reloading works almost always.

In this PR I added debouncing for fsnotify events, path normalization and case handling for Windows.

Somtimes, editors or update jobs do nasty things, which leads to multiple writes or renames.

touch .users.json~ # new config
truncate -s users.json
cat .users.json~ | tee users.json > /dev/null
rm .users.json~
touch .users.json~ # new config
cp -a users.config .users.config-
mv .users.config~ users.config
rm .users.config-

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves automatic authfile reloading by watching the containing directory, debouncing filesystem events, and normalizing paths for matching.

Changes:

  • Watches the authfile parent directory instead of the file itself.
  • Adds path normalization and Windows case-insensitive path comparison.
  • Debounces write/create/rename events before reloading users.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread share/settings/users.go Outdated
Comment thread share/settings/users.go Outdated
Comment thread share/settings/users.go Outdated
@redneck-f25 redneck-f25 force-pushed the improve-config-file-watcher branch from 793a777 to 705d631 Compare May 16, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants