Skip to content

feat(tags): Allow tags to be configured#18

Merged
respectus merged 1 commit into
logdna:masterfrom
SpainTrain:support-tags
Apr 17, 2018
Merged

feat(tags): Allow tags to be configured#18
respectus merged 1 commit into
logdna:masterfrom
SpainTrain:support-tags

Conversation

@SpainTrain
Copy link
Copy Markdown
Contributor

  • New option tags to define logdna host tags

- New option `tags` to define logdna host tags
@respectus respectus merged commit 7c7d5c6 into logdna:master Apr 17, 2018
@SpainTrain
Copy link
Copy Markdown
Contributor Author

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


README.md, line 211 at r1 (raw file):

* _Optional_
* Type: `String[]`

BTW also happy to document this as List<String>


Comments from Reviewable

@SpainTrain SpainTrain deleted the support-tags branch April 17, 2018 21:39
@SpainTrain
Copy link
Copy Markdown
Contributor Author

❤️

@respectus
Copy link
Copy Markdown
Contributor

Thanks for the rapid updates! Your new changes should be on pypi logdna version 1.2.7

@SpainTrain
Copy link
Copy Markdown
Contributor Author

Thanks for the rapid reviews/merges/releases 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants