feat: add listening property in the server interface#1479
Merged
raymondfeng merged 1 commit intoJun 27, 2018
Conversation
Contributor
|
@fernandobastos Thanks for the patch. To be consistent, please also update https://github.com/strongloop/loopback-next/blob/master/packages/http-server/src/http-server.ts to use |
Contributor
|
@fernandobastos Please sign CLA too - https://cla.strongloop.com/agreements/strongloop/loopback-next |
raymondfeng
reviewed
Jun 26, 2018
| private _port: number; | ||
| private _host?: string; | ||
| private _started: Boolean; | ||
| private listening: Boolean; |
Contributor
There was a problem hiding this comment.
It should be private _listening: boolean and add a get function to expose the value so that it's readonly.
private _listening: boolean = false;
get listening() {
return this._listening;
}You should replace get started() with get listening().
raymondfeng
requested changes
Jun 26, 2018
Contributor
|
@fernandobastos Please fix the build error: |
raymondfeng
approved these changes
Jun 27, 2018
Contributor
raymondfeng
left a comment
There was a problem hiding this comment.
Please squash the commit into one.
- Add listening property to Server - Update start and stop methods in RestServer/RpcServer - Update http-server to use listening instead of _started - Update server overview to mention the new property fix #1368
Member
|
@fernandobastos thank you for the contribution ❤️ |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listeningproperty to ServerRestServer/RPCServerto use the new propertyfix #1368
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated