feat(render): snake_case field names display as Title Case#2746
Open
jswir wants to merge 1 commit into
Open
Conversation
getLabel() now converts snake_case to Title Case by default. # label annotation still overrides. Updated all chart axis titles, legend titles, and big-value labels to use getLabel() instead of raw field.name for display. Signed-off-by: James Swirhun <james@credibledata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getLabel()onFieldBasenow converts snake_case field names to Title Case by default (e.g.,avg_retail→ "Avg Retail")# labelannotation still overrides when setgetLabel()instead of rawfield.namefor displaysnakeToTitleCasefrom big-value pluginAffected components
Test plan
avg_retail)# labeloverride still works (Dashboard Dense story has# label='Custom kpi label')