Skip to content

Conversation

Josh-Cena
Copy link
Member

Fix #9923. Still waiting on mdn/shared-assets#62, and then I need to test to fix the actual issue.

@Josh-Cena Josh-Cena requested a review from bsmth August 27, 2025 23:53
@github-actions github-actions bot added Content:Learn Learning area docs Content:Media Media docs size/xl [PR only] >1000 LoC changed labels Aug 27, 2025
Copy link
Contributor

github-actions bot commented Aug 27, 2025 β€’

@Josh-Cena Josh-Cena marked this pull request as ready for review August 28, 2025 21:10
@Josh-Cena Josh-Cena requested review from a team as code owners August 28, 2025 21:10
@sideshowbarker sideshowbarker removed the request for review from a team August 28, 2025 22:54
preload="metadata"
poster="/shared-assets/images/examples/tears-of-steel-battle-clip-medium-poster.jpg">
<source
src="/shared-assets/videos/tears-of-steel-battle-clip-medium.mp4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 20MB, so it takes a while to load. The flower example is 1MB, so this is faster, but maybe less exciting. Plus we have some more features being shown here. Follow-up could be a loading spinner / some feedback indicator that something's happening and playback will start when the resource is ready.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good idea. A bit tricky to do though so perhaps a follow up.

@bsmth
Copy link
Member

bsmth commented Aug 29, 2025

Thanks, Josh. A couple of comments for you to check πŸ‘€

@Josh-Cena Josh-Cena requested a review from bsmth September 1, 2025 19:07
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh! Couple of small things to check, but ready to go when you've had a look πŸ‘€

@Josh-Cena
Copy link
Member Author

Thanks @bsmth for the thorough reviews!

@Josh-Cena Josh-Cena merged commit daad50a into mdn:main Sep 2, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the video-player-ex branch September 2, 2025 15:43
});
volDec.addEventListener("click", (e) => {
alterVolume("-");
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good, that's all we were missing πŸ‘πŸ»

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs Content:Media Media docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content bug: Customized <video> contrast issues
2 participants