Fix: parse mypy diagnostics from stderr in non_interactive mode #375
+10
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
mypy
is run withnon_interactive = True
, it can emit diagnostics tostderr
instead ofstdout
. The extension currently parses onlystdout
, resulting in no diagnostics being shown even though errors are present.Changes
stdout
orstderr
has content, aggregate both and parse the combined output. Continue loggingstdout
as before;stderr
is already logged separately.Rationale
non_interactive
option is set #364 where diagnostics appear in logs but are not processed.Test Plan
setup.cfg
orpyproject.toml
containing:Fixes #364