Revert return dict and wrap apply_chat_template#691
Merged
Conversation
angeloskath
approved these changes
Dec 18, 2025
Member
angeloskath
left a comment
There was a problem hiding this comment.
Very good point! I should have thought of that :-/ ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts a previous change I made using
return_dict=Falseinapply_chat_templateand instead wraps the method.I think it's preferable since it's simpler and doesn't break old examples we have everywhere (e.g. in all our models on Hugging Face).
Also I this is a useful step towards enabling custom chat templates / other tokenization (e.g. for DSV3.2).