Refactor tokenizer error handling to use warnings instead of exceptio…#744
Merged
Merged
Conversation
…ns for missing tool call tokens
Contributor
Author
|
Hi @awni , For example, mlx-community/Ring-mini-linear-2.0-4bit fails because it doesn’t define special tokens for tool calls. In these cases, raising an exception feels a bit too strict — switching to a warning lets the model load normally and tool calls still work as expected. I think this makes the behavior a bit more robust overall. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gracefully handle missing tool call tokens by replacing hard
ValueErrorexceptions with warnings.Previously, initialization would fail if tool call tokens were not found in the tokenizer vocabulary. This change allows the system to continue running while still notifying users via warnings.
Changes
TokenizerWrapper.__init__()to usewarnings.warn()instead of raising aValueErrorimport warningstotokenizer_utils.pyMotivation & Context
This change fixes the model loading failure for
mlx-community/Ring-mini-linear-2.0-4bit, as reported inissue #140.
After this fix, the model loads successfully.
Verification
The following prompt and output demonstrate that tool calling still works correctly after the change.
Input
Output