Sync random seed across ranks in distributed chat#801
Merged
Conversation
awni
reviewed
Jan 23, 2026
|
|
||
| if group.size() > 1: | ||
| seed = mx.distributed.all_sum(mx.random.state[0]).view(mx.uint64).item() | ||
| mx.random.seed(seed) |
Member
There was a problem hiding this comment.
Good catch! But this ignores the seed flag above. Wdyt about instead just setting a default seed and using that?
awni
reviewed
Jan 23, 2026
Comment on lines
+107
to
+108
| if args.seed is None: | ||
| mx.random.seed(0) |
Member
There was a problem hiding this comment.
Nit: you can just set the DEFAULT_SEED=0 so the behavior is consistent in all cases. I think it's fine if the default behavior is seeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue affecting distributed chat where a temperature > 0 would result in ranks having a different random state, causing them to sample different tokens and diverge (often seen as artifacts in the output, shown below).
This fix follows the approach used in #741 and 1d76aab