Fix for Exception - MultiLinear.to_quantized() missing 'mode'#809
Merged
Conversation
Add mode parameter to mixed_quant_predicate_builder as MLX now requires mode to be specified for nn.quantize class_predicate
Member
|
Thanks for the fix. Since the mixed builder really only makes sense for |
inferencers
commented
Jan 29, 2026
Contributor
Author
inferencers
left a comment
There was a problem hiding this comment.
Just a small note: q_mode is being passed to mixed_quant_predicate_builder, but it's no longer needed as mode is now always set to affine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mode parameter to mixed_quant_predicate_builder as MLX now requires mode to be specified for nn.quantize class_predicate
How to reproduce: Try to convert GLM-4.7-Flash with a mixed quant predicate
MLX: v0.30.3