Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove MySQL folder mount
- suspecting that we're not supposed to mount the MySQL folder in the CodeSpaces environment. It looks like our MySQL fails to start for some reason. That's why the 'mysql_service' name does not DNS-resolve unlike 'php' or 'nginx'
Let's try
- also, port 3306 does not need to be exposed in devcontainer.json, unless we try to access it from the outside.
  • Loading branch information
hubertnguyen committed Sep 6, 2023
commit 00cb759293601dd49e05883e9b28159410d19ef7
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
}
},

"forwardPorts": [80,3306],
"forwardPorts": [80],

// execute our one-time repo init if /vendor/ does not exist
"postCreateCommand": "sh init_repo.sh"
Expand Down
16 changes: 8 additions & 8 deletions .devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,20 @@ services:
# the two variales below don't seem to be used at all. Commenting out for now
#MYSQL_USER: myuser
#MYSQL_PASSWORD: mypassword
volumes:
#volumes:
# map local /data/ folder to container /var/lib/mysql for MySQL data persistence
- ${MYSQL_DATA_HOST_PATH}:${MYSQL_DATA_CONTAINER_PATH}
# - ${MYSQL_DATA_HOST_PATH}:${MYSQL_DATA_CONTAINER_PATH}
ports:
- "3306:3306"
# host_port:container_port


redis:
image: redis:latest
ports:
- "6379:6379"
volumes:
- ${REDIS_DATA_HOST_PATH}:${REDIS_DATA_CONTAINER_PATH}
# redis:
# image: redis:latest
# ports:
# - "6379:6379"
# volumes:
# - ${REDIS_DATA_HOST_PATH}:${REDIS_DATA_CONTAINER_PATH}

# Notes:
#
Expand Down