fix: Use JSON Encoder by default to respond to requests

[cbaker6]

No description provided.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Added new Swift package dependencies, including support for ASN.1, async algorithms, certificates, and service lifecycle.

• Bug Fixes

  • Updated the encoder registration for JSON content to improve encoding behavior.

• Chores

  • Upgraded multiple package dependencies to newer versions.
  • Made minor corrections to repository URLs in the dependency list.

Walkthrough

The update upgrades several Swift package dependencies, adds new packages, and adjusts repository URLs in Package.resolved. The Package.swift file updates version constraints for Vapor and Parse-Swift dependencies. In the source code, the encoder registration for JSON content is switched to use User.getJSONEncoder() instead of User.getEncoder() in the ParseServerSwift initialization.

Changes

Cohort / File(s)	Change Summary
Dependency Version Bumps & Additions Package.resolved	Upgraded multiple package versions, added new dependencies (swift-asn1, swift-async-algorithms, swift-certificates, swift-service-lifecycle), and corrected repository URLs.
Package Version Constraint Updates Package.swift	Updated Vapor version to 4.115.1 and Parse-Swift version to 5.12.3 using .upToNextMajor.
Encoder Registration Change Sources/ParseServerSwift/Parse.swift	Changed JSON encoder registration from User.getEncoder() to User.getJSONEncoder().

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant ContentConfig
    participant User

    App->>ContentConfig: Register JSON encoder (User.getJSONEncoder())
    App->>ContentConfig: Register JSON decoder (User.getDecoder())

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🎉
New versions rise, dependencies align,
Encoders swapped—JSON will shine!
URLs fixed, new friends appear,
The code grows stronger, never fear!
Plus Ultra changes, swift and bright,
Onward, heroes—review in sight! 🚀

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5d5b5c and 1969b08.

📒 Files selected for processing (3)

• Package.resolved (1 hunks)
• Package.swift (1 hunks)
• Sources/ParseServerSwift/Parse.swift (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: linux
• GitHub Check: docs
• GitHub Check: spm-test

🔇 Additional comments (6)

Sources/ParseServerSwift/Parse.swift (2)

56-57: Confirm Intent for Symmetric Naming! Plus Ultra!

I’ve searched the codebase and there is no getJSONDecoder()—only User.getDecoder() is defined and used (in Parse.swift and the tests). Please confirm that:

• User.getDecoder() is indeed a JSON‐decoder under the hood.
• You’re happy with the asymmetrical naming, or if you’d prefer to rename it (or add a getJSONDecoder()) for clarity.

Keep up the heroic work!

---

56-56: Plus Ultra! JSON Encoder Verified and Ready for Launch!

The change from User.getEncoder() to User.getJSONEncoder() perfectly aligns with the PR’s goal of defaulting to a JSON-specific encoder. I’ve confirmed that getJSONEncoder() is defined and in active use across the codebase:

• Sources/ParseServerSwift/Parse.swift (line 56)
• Sources/ParseServerSwift/Extensions/Parse+Vapor.swift (line 80)
• Tests/ParseServerSwiftTests/AppTests.swift (line 224)

The decoder remains User.getDecoder(), maintaining the intended asymmetry for decoding. With everything in place and verified, this change is approved—onward to Plus Ultra functionality!

Package.swift (2)

24-24: Approve version bumps – Plus Ultra!

I’ve confirmed Vapor 4.115.1 adds only Sendable annotations for OTP types (no breaking changes; backward-compatible¹²), and Parse-Swift 5.12.3 is a straight patch upgrade. Both are safe to merge—let’s fly higher!

Citations:

1. https://forum.devtalk.com/t/vapor-4-115-1-released/206825?utm_source=openai
2. https://github.com/vapor/vapor/releases?utm_source=openai

---

28-28: Verify JSON Encoder Support in Parse-Swift 5.12.3! Plus Ultra!

Young hero! The jump from 5.12.0 → 5.12.3 brings direct file uploads and Swift-native Cloud Code hooks—but the release notes don’t mention getJSONEncoder(). Before we charge ahead, please confirm that the getJSONEncoder() method (or its equivalent) is available in Parse-Swift v5.12.3 by inspecting the SDK’s API docs or source.

• File: Package.swift (line 28 – dependency version)
• Action: Review Parse-Swift v5.12.3 source or documentation for getJSONEncoder()

Once confirmed, we can approve this update with full confidence!

Package.resolved (2)

44-45: Plus Ultra! The resolved versions match our Package.swift updates perfectly!

I can see the Parse-Swift resolution at version 5.12.3 and Vapor at 4.115.1 match exactly with the Package.swift version constraints. The commit hashes look legitimate and current.

Also applies to: 251-252

---

66-82: New heroic dependencies have joined the team!

The addition of swift-asn1, swift-async-algorithms, swift-certificates, and swift-service-lifecycle are likely transitive dependencies brought in by the Vapor or Parse-Swift version updates. These are all legitimate Apple and Swift Server Working Group packages that enhance security and async capabilities.

Also applies to: 93-100, 227-235

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch encoderUpdates

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.23%. Comparing base (c5d5b5c) to head (1969b08).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   37.93%   35.23%   -2.70%     
==========================================
  Files          11       11              
  Lines        1189     1189              
==========================================
- Hits          451      419      -32     
- Misses        738      770      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.