Skip to content

improve: cleaner throws Exception #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
Merged

improve: cleaner throws Exception #2527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cbd44b
improve: cleaner throws Exception
csviri Sep 6, 2024
b7ddc83
fix
csviri Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Cleaner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ public interface Cleaner<P extends HasMetadata> {
* that it can be safely deleted.
* @see DeleteControl#noFinalizerRemoval()
*/
DeleteControl cleanup(P resource, Context<P> context);
DeleteControl cleanup(P resource, Context<P> context) throws Exception;

}
2 changes: 1 addition & 1 deletion operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ public Map<String, Object> metadata() {
}

@Override
public DeleteControl execute() {
public DeleteControl execute() throws Exception {
initContextIfNeeded(resource, context);
WorkflowCleanupResult workflowCleanupResult = null;

Expand Down
Loading