CoW: disable chained assignment detection for Python 3.14 #62324
+48
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for leaving my authorship on one of the commits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: this disables all chained assignment warnings in case of Python 3.14+, but afterwards #62070 will enable it again specifically for the chained setitem indexing.
@ngoldbaum I extracted the warning disable parts from #61950. I had removed it from that PR thinking we won't need it because of my follow-up PR #62070, but in the end we still need the disabling for the inplace methods (my PR for now only fixes the indexing cases), and we might also need it if we want to backport the python 3.14 support to 2.3.x