Add workaround for release publishing action mishandling draft: true -> false transition#444
Merged
Conversation
draft: true -> false transition
benjyw
approved these changes
Dec 12, 2024
Contributor
benjyw
left a comment
There was a problem hiding this comment.
Hopefully that PR gets upstreamed soon... Can we prompt them about it?
1 task
Contributor
Author
|
I've left a comment because it seemed like seeing real world usage was part of the review process, good call-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around
softprops/action-gh-releasenot being able to properly "publish" a release by changingdraft: truetodraft: false.The intention is that the step with
draft: falsewould find the existing draft release and update it (publishing it). This is what correctly happened for a testingv0.12.3-beta.3release from this branch: https://github.com/pantsbuild/scie-pants/releases/tag/v0.12.3-beta.3 (I also did attempted av0.12.3-beta.2from this branch, but that used a newer version of the action code and failed completely, see below.)Previously, the action would fail to find the existing draft release and instead create a duplicate one. The old behaviour is visible (to people who can see draft releases) with
v0.12.3-beta.0and-beta.1:The particular new version of the action is:
v2tag) with fix: updating release draft status from true to false softprops/action-gh-release#316 merged inRequest body length does not match content-length header, so this sticks with the older version.