CS: Various phpcs tweaks #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8971807 to
92a485b
Compare
The current version is `3.5.4` released end of January 2020 and - aside from lots of bug fixes -, it includes compatibility with PHP 7.4. See: https://github.com/squizlabs/php_codesniffer/releases
The results of PHPCS run will be no different across PHP versions as all sniffs are unit tested against all supported PHP versions, so it is unnecessary to run it against every PHP version, just run it once per build. I've chosen to run it against PHP 7.4 as that's the fastest PHP version.
* Rename the ruleset to one which PHPCS will recognize automatically.
This means you no longer need to pass the `--standard` on the command-line.
* Use the `dist` extension to allow for devs to overload the ruleset file locally and gitignore the typical overload file names which are recognized by PHPCS by default.
* Ruleset/Travis: move command-line arguments to the project ruleset.
... and scan all PHP files, not just the files in `src`.
* Ruleset: also scan the `phpt` test files.
* Ruleset: enable parallel scanning.
* Ruleset: set the basepath for a cleaner output report.
* Ruleset: add the PHPCS XML scheme.
* Ruleset: selectively exclude the `skip-linting.php` file for the `Generic.PHP.NoSilencedErrors` rule.
92a485b to
c1d07cf
Compare
|
Rebased to fix conflict status. |
|
It look's good, thank you :-) |
|
You're welcome ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as previously pulled in PR JakubOnderka/PHP-Parallel-Lint#146
Composer: update the PHPCS dependency
The current version is
3.5.4released end of January 2020 and - aside from lots of bug fixes -, it includes compatibility with PHP 7.4.See: https://github.com/squizlabs/php_codesniffer/releases
Travis: only run PHPCS once
The results of PHPCS run will be no different across PHP versions as all sniffs are unit tested against all supported PHP versions, so it is unnecessary to run it against every PHP version, just run it once per build.
I've chosen to run it against PHP 7.4 as that's the fastest PHP version.
PHPCS: tweak ruleset
This means you no longer need to pass the
--standardon the command-line.distextension to allow for devs to overload the ruleset file locally and gitignore the typical overload file names which are recognized by PHPCS by default.... and scan all PHP files, not just the files in
src.phpttest files.skip-linting.phpfile for theGeneric.PHP.NoSilencedErrorsrule.CS: minor clean up