Skip to content

core: set zend_pass_function as default constructor #19797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

core: set zend_pass_function as default constructor #19797

wants to merge 1 commit into from
+255 −121

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Sep 11, 2025

This is to make the semantics of when a class cannot be instantiated obvious, rather than needed to remember to call the get_constructor() handler and discard the exception.

Possible solution to #17796

Very much W.I.P.

@Girgias Girgias force-pushed the default-pass-ctor branch 3 times, most recently from bf13ae2 to e89c0d3 Compare September 11, 2025 08:39
@Girgias Girgias force-pushed the default-pass-ctor branch 2 times, most recently from cc51c73 to 5508388 Compare September 11, 2025 12:29
@Girgias
core: set zend_pass_function as default constructor
dfbe9aa 
This is to make the semantics of when a class cannot be instiantiated obvious rather than needed to remember to call the get_constructor() handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov Awaiting requested review from dstogov dstogov will be requested when the pull request is marked ready for review dstogov is a code owner

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos will be requested when the pull request is marked ready for review nielsdos is a code owner

@bukka bukka Awaiting requested review from bukka bukka will be requested when the pull request is marked ready for review bukka is a code owner

@DanielEScherzer DanielEScherzer Awaiting requested review from DanielEScherzer DanielEScherzer will be requested when the pull request is marked ready for review DanielEScherzer is a code owner

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla will be requested when the pull request is marked ready for review TimWolla is a code owner

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi will be requested when the pull request is marked ready for review zeriyoshi is a code owner

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi will be requested when the pull request is marked ready for review SakiTakamachi is a code owner

@kamil-tekiela kamil-tekiela Awaiting requested review from kamil-tekiela kamil-tekiela will be requested when the pull request is marked ready for review kamil-tekiela is a code owner

Assignees
No one assigned
Labels
ABI break Category: Engine Category: Optimizer Extension: dom Extension: mysqli Extension: pdo (core) Extension: random Extension: reflection Extension: session Extension: spl Extension: standard Extension: xmlreader Extension: xmlwriter Extension: xsl Extension: zend_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Girgias