fix: checking optional properties in object shapes #4328
+35
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c408b3 to
bae03bd
Compare
|
don't get confused by the CI results.. we currently investigate spurious CI errors |
ondrejmirtes
requested changes
Sep 13, 2025
bae03bd to
d28fb04
Compare
d28fb04 to
692b5be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Closes phpstan/phpstan#13511
By the time the
getProperty()method is called, the$hasPropertyhas already been narrowed tomaybeor it's been determined to be optional and overridden toyes. We should simply continue instead of returningnoThanks!