Skip to content

Add BrowserKitAssertionTraitReturnTypeExtension #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 2.0.x
Choose a base branch
from
Open

Add BrowserKitAssertionTraitReturnTypeExtension #452

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef09fcd
Add BrowserKitAssertionTraitReturnTypeExtension
VincentLanglet Aug 30, 2025
204e0e3
Failing test
VincentLanglet Aug 30, 2025
c7e1125
Fix
VincentLanglet Aug 30, 2025
2b57a14
Rework
VincentLanglet Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Failing test
  • Loading branch information
@VincentLanglet
VincentLanglet committed Aug 30, 2025
commit 204e0e3ac650eb5601a21750b556fd0eb7c97667
3 changes: 2 additions & 1 deletion tests/Type/Symfony/data/browserkit_assertion_trait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
class Foo {
use BrowserKitAssertionsTrait;

public function test(AbstractBrowser $browser, ?AbstractBrowser $nullableBrowser)
public function test(AbstractBrowser $browser, ?AbstractBrowser $nullableBrowser, mixed $mixed)
{
assertType('Symfony\Component\BrowserKit\AbstractBrowser', $this->getClient());
assertType('null', $this->getClient(null));
assertType('Symfony\Component\BrowserKit\AbstractBrowser', $this->getClient($browser));
assertType('Symfony\Component\BrowserKit\AbstractBrowser|null', $this->getClient($nullableBrowser));
assertType('Symfony\Component\BrowserKit\AbstractBrowser|null', $this->getClient($mixed));
}
}
Loading