Skip to content

FIX selector = 0 returns all traces in select_traces #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2023
Merged

FIX selector = 0 returns all traces in select_traces #3817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
321c772
Avoid selecting all traces on selector=0
wf-r Jul 19, 2022
2e20540
Update tests
wf-r Jul 19, 2022
143ecfd
Update test_update_traces.py
wf-r Aug 1, 2022
fb7bd75
Update test_update_traces.py
wf-r Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/python/plotly/plotly/basedatatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ def select_traces(self, selector=None, row=None, col=None, secondary_y=None):
Generator that iterates through all of the traces that satisfy
all of the specified selection criteria
"""
if not selector:
if not selector and not isinstance(selector, int):
selector = {}

if row is not None or col is not None or secondary_y is not None:
Expand Down
4 changes: 4 additions & 0 deletions packages/python/plotly/plotly/tests/test_core/test_update_objects/test_update_traces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,10 @@ def select_traces_fixture():

def test_select_traces_integer(select_traces_fixture):
fig = select_traces_fixture
# check that selecting first trace does indeed only select the first
tr = list(fig.select_traces(selector=0))
assert len(tr) == 1
assert tr[0].y[1] == 0
# check we can index last trace selected
tr = list(fig.select_traces(selector=-1))[0]
assert tr.y[1] == 20
Expand Down