Skip to content

Conversation

gmjw
Copy link

@gmjw gmjw commented Sep 5, 2025

As per the docs, if z is passed in with no histfunc, it should be set to 'sum':

image

I think this corrects the intended behaviour and puts Histogram2dContour more in line with Histogram2d.

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@gmjw gmjw changed the title fix Small fix to Histogram2dContour setup in plotly express Sep 5, 2025
@gmjw
Copy link
Author

gmjw commented Sep 5, 2025

If a more experienced contributor takes a look at this - I can't understand why the Circle CI build has failed, the error message doesn't indicate anything clearly - any advice appreciated.

@gvwilson gvwilson self-assigned this Sep 9, 2025
@gvwilson gvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Sep 9, 2025
@gvwilson
Copy link
Contributor

gvwilson commented Sep 9, 2025

thanks @gmjw - much appreciated. the broken Circle CI job isn't your fault - we're working on it…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution fix fixes something broken P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants