Improve PlayButton with Preferences and Error Handling; Fix Manual Route Param Handling#561
Merged
Merged
Conversation
prayag17
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
PlayButtoncomponent insrc/components/buttons/playButton.tsx, focusing on user preferences for subtitles and audio, improved handling of series episodes, and better error handling. Additionally, there is a minor fix in themanual.tsxroute to handle undefined search parameters gracefully.Enhancements to
PlayButtonfunctionality:Subtitle and audio preferences support:
getUserApi. The preferred subtitle and audio tracks are now selected based on these preferences, with fallbacks to default or first available options.Improved handling of series episodes:
iconOnlycondition to ensure proper handling of series episodes by dynamically determining the current episode ID. This includes disabling the button when no episodes are available or when data is still loading.Error handling improvements:
currentEpisode.data. This includes null-safe access to properties likeItems,IndexNumber, andPlaybackPositionTicks.Minor fix in
manual.tsx:validateSearchfunction insrc/routes/_api/login/manual.tsxto handle cases wheresearch.redirectis undefined, ensuring the return value is either a string orundefinedinstead of throwing an error.