Skip to content

chore(ci): Advance velox#27802

Open
amitkdutta wants to merge 1 commit into
prestodb:masterfrom
amitkdutta:new_vel90
Open

chore(ci): Advance velox#27802
amitkdutta wants to merge 1 commit into
prestodb:masterfrom
amitkdutta:new_vel90

Conversation

@amitkdutta
Copy link
Copy Markdown
Contributor

@amitkdutta amitkdutta commented May 14, 2026

== NO RELEASE NOTE ==

Summary by Sourcery

Chores:

  • Update the Velox submodule reference under presto-native-execution to the latest desired commit.

@amitkdutta amitkdutta requested review from a team as code owners May 14, 2026 16:42
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label May 14, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request advances the Velox submodule reference used by presto-native-execution to a newer upstream commit, with no additional code or configuration changes in this repository.

File-Level Changes

Change Details Files
Update the Velox submodule pointer to a newer upstream commit.
  • Advance the git reference for the Velox dependency used by presto-native-execution.
  • Incorporate all upstream Velox changes between the previous and new commit without local modifications in this repo.
presto-native-execution/velox

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@aditi-pandit
Copy link
Copy Markdown
Contributor

The failure is valid. Analysis from Co-pilot.
@amitkdutta


The failure is caused by a stale Homebrew package reference in the workflow, not by the C++ build itself.

Root cause

The job completes dependency builds and then fails at:

brew link --force protobuf@21

Error from the log:

No such keg: /opt/homebrew/Cellar/protobuf@21

This means the macOS runner no longer has protobuf@21 installed or available under that formula name. The failing line is in the workflow file:

  • .github/workflows/prestocpp-macos-build.yml:100
brew link --force protobuf@21

Solution

Update the workflow to stop linking a versioned formula that no longer exists on the runner.

Recommended fix

Replace:

brew link --force protobuf@21

with:

brew link --overwrite protobuf

or, if linking is unnecessary, remove the line entirely.

Suggested patch

In .github/workflows/prestocpp-macos-build.yml:

@@
-          brew link --force protobuf@21
+          brew link --overwrite protobuf

Why this is the right fix

  • The logs show all earlier “ERROR” separators are just log chunk markers around dependency builds; the actual fatal error is the final Homebrew keg lookup failure.
  • The workflow never installs protobuf@21, so linking it is brittle.
  • On current GitHub macOS images, protobuf is the maintained formula name, while protobuf@21 may no longer be present.
  • Using protobuf aligns the workflow with current Homebrew packaging and avoids pinning to a removed keg.

If Presto specifically requires protobuf 21

If that version is truly required, make the workflow install it before linking, but that is less robust because Homebrew may have dropped the versioned formula. For example:

brew install protobuf
brew link --overwrite protobuf

Focused recommendation

Make this one-line workflow change:

brew link --overwrite protobuf

at .github/workflows/prestocpp-macos-build.yml:100. This should fix job 76069021787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants