Skip to content

Conversation

jbaremoney
Copy link

Description

In the backpropagation section, there was a comment saying the code was computing the gradient of parameters a, b, c, d wrt the loss. This is flipped and causes confusion about the math of backprop.

Specifically, the original comment:

“Backprop to compute gradients of a, b, c, d with respect to loss”

has been changed to:

“Backprop to compute gradient of the loss with respect to parameters a, b, c, d”

Checklist

  • The issue (if any) that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • At most one issue is addressed in this pull request
  • Labels from the issue (if any) that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

In the backpropagation section, there was a comment saying the code was computing the gradient of parameters a, b, c, d wrt the loss. This is flipped and causes confusion about the math of backprop.
Copy link

pytorch-bot bot commented Sep 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3558

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

meta-cla bot commented Sep 12, 2025

Hi @jbaremoney!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the cla signed label Sep 12, 2025
Copy link

meta-cla bot commented Sep 12, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant