Update editor-setup.md #7945
Open
Update editor-setup.md #7945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update editor setup docs to recommend eslint-plugin-react and eslint-plugin-react-hooks
Size changesπ¦ Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. π€ This PR introduced no changes to the JavaScript bundle! π |
rickhanlonii
reviewed
Sep 2, 2025
| @@ -36,7 +36,7 @@ Code linters find problems in your code as you write, helping you fix them early | |||
| * [Install ESLint with the recommended configuration for React](https://www.npmjs.com/package/eslint-config-react-app) (be sure you have [Node installed!](https://nodejs.org/en/download/current/)) | |||
| * [Integrate ESLint in VSCode with the official extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) | |||
|
|
|||
| **Make sure that you've enabled all the [`eslint-plugin-react-hooks`](https://www.npmjs.com/package/eslint-plugin-react-hooks) rules for your project.** They are essential and catch the most severe bugs early. The recommended [`eslint-config-react-app`](https://www.npmjs.com/package/eslint-config-react-app) preset already includes them. | |||
| **Make sure that you've enabled all the [`eslint-plugin-react-hooks`](https://www.npmjs.com/package/eslint-plugin-react-hooks) rules in your project.** They are essential and catch the most severe bugs early. If youβre setting up linting manually, we recommend using both [`eslint-plugin-react`](https://www.npmjs.com/package/eslint-plugin-react) and [`eslint-plugin-react-hooks`](https://www.npmjs.com/package/eslint-plugin-react-hooks). If youβre using the new ESLint flat config format, you can extend the configs included with those plugins. | |||
There was a problem hiding this comment.
See my comment in the issue - I don't think we should recommend one or the other. The goal here is to inform users that if they are using one of the config presets, it's already included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update editor setup docs to recommend eslint-plugin-react and eslint-plugin-react-hooks
#7932