-
-
Notifications
You must be signed in to change notification settings - Fork 253
Add GADT documentation to the manual #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry for the format check shenanigans - should be fixed when you update to the latest master commit now. |
Ignore format check of API json files (rescript-lang#1097)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
Besides my comments, can you please make all code camelCased?
Usually, we try to be a bit more concise with our docs, but here understanding the big picture is key so I found it quite nice how it is.
Thanks for the feedback -- I think I managed to get everything. Regarding the RWO reference, I removed any direct mention of OCaml -- just a quick footnote linking the RWO chapter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Thank you so much!
This adds an initial version of documentation for GADTs with a thorough tutorial.
I edited this from my original forum post for clarity and added a practical
example -- writing bindings to Node's stream API.
Feedback and further refinement welcome!
fixes: #153