Skip to content

Update preact generic module #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2025
Merged

Update preact generic module #1106

merged 2 commits into from
Sep 8, 2025

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Sep 8, 2025

I just tried this out in a new project and the bindings were not working for me.
jsx needs to come from preact/jsx-runtime.

I also want to have a copy/paste button, so made some changes to have:
image

@nojaf nojaf requested a review from fhammerschmidt September 8, 2025 11:52
@fhammerschmidt
Copy link
Member

Thanks!
Do they work on ReScript 11?

@fhammerschmidt
Copy link
Member

Oh, it might depend on your Preact version, right?

@nojaf
Copy link
Member Author

nojaf commented Sep 8, 2025

Latest preact major has been the same for 6 years now.
So, I'm updating the text as well for v11.
That worked as well for me.

@nojaf nojaf merged commit 4e4fabe into rescript-lang:master Sep 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nojaf @fhammerschmidt