Skip to content

add Scala 3 build #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add Scala 3 build #29

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c9ea6b
fix scala 3 warning. remove redundant final
xuwei-k Sep 13, 2025
f153f81
fix waitOnMessage
xuwei-k Sep 13, 2025
73999f0
update sbt version
xuwei-k Sep 25, 2025
b614fb0
add Scala 3 build
xuwei-k Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix scala 3 warning. remove redundant final
  • Loading branch information
@xuwei-k
xuwei-k committed Sep 14, 2025
commit 5c9ea6bb9aee7a7a04b7282d3cc0f83c98294d5c
2 changes: 1 addition & 1 deletion js-envs/src/main/scala/org/scalajs/jsenv/RunConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ final class RunConfig private (
}
}

final object RunConfig {
object RunConfig {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[error] 122 |final object RunConfig {
[error]     |^^^^^
[error]     |Modifier final is redundant for this definition

type OnOutputStream = (Option[InputStream], Option[InputStream]) => Unit
def apply(): RunConfig = new RunConfig()

Expand Down
2 changes: 1 addition & 1 deletion nodejs-env/src/main/scala/org/scalajs/jsenv/nodejs/ComSupport.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ object ComRun {
jvm2js: DataOutputStream,
js2jvm: DataInputStream) extends State

private final case object Closing extends State
private case object Closing extends State

private def writeMsg(s: DataOutputStream, msg: String): Unit = {
s.writeInt(msg.length)
Expand Down