-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Only nullfiy simple kinded types #23911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HarrisL2
wants to merge
2
commits into
scala:main
Choose a base branch
from
HarrisL2:23908
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,10 +107,13 @@ object ImplicitNullInterop { | |
case tp: TypeRef if !tp.hasSimpleKind | ||
// We don't modify value types because they're non-nullable even in Java. | ||
|| tp.symbol.isValueClass | ||
|| tp.isRef(defn.NullClass) | ||
|| tp.isRef(defn.NothingClass) | ||
// We don't modify unit types. | ||
|| tp.isRef(defn.UnitClass) | ||
// We don't modify `Any` because it's already nullable. | ||
|| tp.isRef(defn.AnyClass) => false | ||
case tp: TypeParamRef if !tp.hasSimpleKind => false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
case _ => true | ||
|
||
// We don't nullify Java varargs at the top level. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import unsafeNulls.Foo.* | ||
import unsafeNulls.Unsafe_1 | ||
import unsafeNulls.{A, B, C, F, G, H, I, J, L, M, S, T, U, expects} | ||
import unsafeNulls.{A, B, C, F, G, H, I, J, L, M, N, S, T, U, expects} | ||
import scala.reflect.Selectable.reflectiveSelectable | ||
import scala.quoted.* | ||
|
||
|
@@ -100,6 +100,11 @@ def Flexible_2() = | |
|
||
val m: String = M.test(null) | ||
|
||
// i23911 | ||
val n1: List[Map[String, Int]] = ??? | ||
val n2 = new N[List]() | ||
val n3 = n2.accept[Any](n1) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's also test some type lambdas like |
||
// i23845 | ||
transparent inline def typeName[A]: String = ${typeNameMacro[A]} | ||
|
||
|
@@ -109,3 +114,4 @@ def Flexible_2() = | |
implicit val givenS: S[A] = ??? | ||
expects(alphaTypeNameMacro[A]) | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also need to consider the following special classes:
SingletonClass
,AnyKindClass
,FromJavaObjectSymbol
, etc...