Parameterize Node DynamicLabels #3034
Conversation
garbybaby
commented
Aug 7, 2025
- You have read the Spring Data Neo4j contribution guidelines.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
Signed-off-by: Garby Baby <garbybaby@gmail.com>
| @@ -303,6 +303,10 @@ public Statement prepareSaveOf(NodeDescription<?> nodeDescription, | |||
| String primaryLabel = nodeDescription.getPrimaryLabel(); | |||
| List<String> additionalLabels = nodeDescription.getAdditionalLabels(); | |||
|
|
|||
| List<String> additionalLabelsNew = new ArrayList<>(additionalLabels); | |||
| additionalLabelsNew.addAll(nodeDescription.getDynamicLabels()); | |||
| Node rootNodeWithDynamicLabels = node(primaryLabel, additionalLabelsNew).named(Constants.NAME_OF_TYPED_ROOT_NODE.apply(nodeDescription)); | |||
There was a problem hiding this comment.
This still generates a non-parametrized query for @DynamicLabels.
| @@ -60,4 +66,8 @@ public OngoingMatchAndUpdate apply(OngoingMatchAndUpdate ongoingMatchAndUpdate) | |||
| } | |||
There was a problem hiding this comment.
oldLabels.toArray(new String[0]) -> Cypher.parameter("oldLabels")
newLabels.toArray(new String[0]) -> Cypher.parameter("newLabels")
Parameter names are to be added to Constants and populated to the query when running it.
|
Hej there. Thanks for the PR. There are no tests, hence I might be wrong in my assumption that the change will require an additional set of additional labels next to the additional labels we already have, that you called dynamic labels? SDN does support dynamic labels already on the mapping side of things. The goal must be to translate those to either
For the latter we would of course be using Cypher DSL. Over there, we don't support dynamic label expressions yet. Hence, I think we should add this there, and than rely on the configured dialect so that Cypher-DSL does the correct thing. |
|
I created in issue for the Cypher-DSL work neo4j/cypher-dsl#1314 |
|
@michael-simons By dynamic labels we meant only labels managed by SDN in |
|
@michael-simons Would you mind if we close this PR and leave it for you to finish the implementation? Given the missing and upcoming support in Cypher DSL, it's apparent it's more complex then we thought :) |
|
@zakjan I got that (wrt dynamic labels), and I do fully get behind that we should translate the SDN feature to the new Cypher feature. We should have done this before. Wrt this PR, do as you see fit, I am fine with both keeping it open or doing a fresh. Happy to help you and your colleague to get PR in. |