Audit all quotes and regexes

[sudar]

One example where the regex failed is #190 (comment)

Another place where things might break is Windows path handling

[sej7278]

This is going to be a lot of work - i can't even get a sketch to compile or find its libraries if its in a path with a space in it - on linux at least - that said, even the IDE seems to crash if the sketch or directory has a space in it.

I've caught a few instances of grep and cat that need to be quoted:

"$(VERSION_FILE)" on line 302
"$(ARDUINO_PREFERENCES_PATH)" on line 334
"$(BOARDS_TXT)" on lines 523, 1264
"$(ARDMK_DIR)/arduino-mk-vars.md" on line 1289

But things like include don't respect quotes and probably need something to escape them automagically.

good reference

[sej7278]

Why are we not just calling rm -rf ./$(OBJDIR) with some sanity checks for make clean instead of:

clean:
        $(REMOVE) $(LOCAL_OBJS) $(CORE_OBJS) $(LIB_OBJS) $(CORE_LIB) \
           $(TARGETS) $(DEPS) $(USER_LIB_OBJS) ${OBJDIR}

As when playing with spaces in directory/file-names, i found that $(TARGETS) is set to a wildcard and could lead to your sketch being deleted.

[sudar]

Why are we not just calling rm -rf ./$(OBJDIR) with some sanity checks for make clean instead of

I think this is because of legacy reasons. Earlier we were creating all the extra files in the same directory.

[sej7278]

I think this is because of legacy reasons. Earlier we were creating all the extra files in the same directory.

yes it looks like ${OBJDIR} was tacked on the end of the list

[sej7278]

think we can close this now, i did the audit and provided some fixes