Skip to content

fix: onboarding bounce rate#942

Open
MaheshtheDev wants to merge 1 commit into
mainfrom
05-14-fix_onboarding_bounce_rate
Open

fix: onboarding bounce rate#942
MaheshtheDev wants to merge 1 commit into
mainfrom
05-14-fix_onboarding_bounce_rate

Conversation

@MaheshtheDev
Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 14, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp b56fe7f May 14 2026, 07:27 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 14, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app b56fe7f Commit Preview URL May 14 2026, 07:28 AM

@MaheshtheDev MaheshtheDev marked this pull request as ready for review May 14, 2026 07:26
Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude Bot commented May 14, 2026

Claude finished @MaheshtheDev's task in 1m 13s —— View job


Reviewing PR #942

  • Get PR diff and review changes
  • Check surrounding code context
  • Check for existing review comments
  • Post review summary

Summary

This PR adds a catch-all route ([...slug]) to redirect any invalid onboarding sub-paths back to /onboarding.

No issues found — clean implementation that correctly uses Next.js server-side redirect with no risk of infinite loops or breaking existing routes.

Score: 10/10

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a catch-all route to redirect invalid onboarding sub-paths (e.g., /onboarding/step1, /onboarding/foo) back to /onboarding.

Issues found: None — this looks good to ship.

The implementation is clean:

  • Uses Next.js redirect() correctly (server-side redirect)
  • No infinite redirect risk since /onboarding routes to the main page, not the catch-all
  • No existing sub-routes under /onboarding that would be broken by this change
  • API routes under /api/onboarding/* are unaffected

Score: 10/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant