fix: exclude overridable annotation values when parsing composed annotations#5179
Open
Mattias-Sehlstedt wants to merge 1 commit into
Open
Conversation
91852e9 to
ad6b598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
Change the meta-annotation parsing so that annotations that utilize
@OverridesAttributedo not take the overridden annotation into consideration. This since the library currently does not support parsing the@OverridesAttributevalue definition.I know that the Hibernate validator most likely has code to manage this, but I do not believe that is a dependency that this project needs or wants as of now. Both swagger-core and springdoc-openapi both have extension possibilities for injecting interpretation logic of annotations, so that is how these annotations can be managed currently.
Fixes: #5178
Type of Change
Checklist
Screenshots / Additional Context