Update ASV config to SymPy 1.14 and CI to Python 3.14#109
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the CI configuration to use newer versions of SymPy and Python. The changes aim to keep the benchmark suite tracking recent SymPy releases and running on a more current Python version.
Changes:
- Updated SymPy branch version from 1.12 to 1.14 in the ASV benchmark configuration
- Updated Python version from 3.10 to 3.14 in the GitHub Actions workflow
- Removed explicit Python version configuration from asv.conf.actions.json, allowing it to default to the version specified in the workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| asv.conf.actions.json | Updates SymPy branch to 1.14 and removes redundant Python version specification |
| .github/workflows/run-benchmarks.yml | Updates Python version to 3.14 for running benchmarks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -16,7 +16,7 @@ jobs: | |||
| - name: Setup Python | |||
| uses: actions/setup-python@v3 | |||
There was a problem hiding this comment.
The setup-python action is using v3, which may not support Python 3.14 even when it's released. Consider updating to v5 (the latest version as of early 2025) to ensure better support for newer Python versions. This is particularly important if you intend to use Python 3.13 or any future Python versions.
| uses: actions/setup-python@v3 | |
| uses: actions/setup-python@v5 |
| // This list needs to be updated after each release of sympy. The branch to | ||
| // be checked should always be the previous release. | ||
| "branches": ["1.12", "master", "HEAD"], // for git | ||
| "branches": ["1.14", "master", "HEAD"], // for git |
There was a problem hiding this comment.
Verify that SymPy 1.14 has been released. The comment on line 30-31 indicates this should be the previous release version. If SymPy 1.14 hasn't been released yet, this will cause the benchmarks to fail when trying to check out this branch from the SymPy repository. You can verify the existence of this branch/tag at https://github.com/sympy/sympy.
| "branches": ["1.14", "master", "HEAD"], // for git | |
| "branches": ["1.13", "master", "HEAD"], // for git |
|
I have disabled Copilot review. Actually, I don't like it since it's not that much useful. I thought It was turned it on at the org level. Now I find it in my settings, hoping that from the next PR onward it will not review. |
|
Might need to rebase. |
26ed5a1 to
4b50d74
Compare
4b50d74 to
a97e685
Compare
References to other Issues or PRs
Brief description of what is fixed or changed
This pr updates
AI Generation Disclosure