Skip to content

Update ASV config to SymPy 1.14 and CI to Python 3.14#109

Open
vprayag2005 wants to merge 1 commit into
sympy:masterfrom
vprayag2005:update-ci
Open

Update ASV config to SymPy 1.14 and CI to Python 3.14#109
vprayag2005 wants to merge 1 commit into
sympy:masterfrom
vprayag2005:update-ci

Conversation

@vprayag2005
Copy link
Copy Markdown
Contributor

@vprayag2005 vprayag2005 commented Feb 23, 2026

References to other Issues or PRs

Brief description of what is fixed or changed

This pr updates

  • asv.conf.actions.json to uses sympy 1.14
  • CI to use use python 3.14

AI Generation Disclosure

Copilot AI review requested due to automatic review settings February 23, 2026 07:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the CI configuration to use newer versions of SymPy and Python. The changes aim to keep the benchmark suite tracking recent SymPy releases and running on a more current Python version.

Changes:

  • Updated SymPy branch version from 1.12 to 1.14 in the ASV benchmark configuration
  • Updated Python version from 3.10 to 3.14 in the GitHub Actions workflow
  • Removed explicit Python version configuration from asv.conf.actions.json, allowing it to default to the version specified in the workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
asv.conf.actions.json Updates SymPy branch to 1.14 and removes redundant Python version specification
.github/workflows/run-benchmarks.yml Updates Python version to 3.14 for running benchmarks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/run-benchmarks.yml Outdated
@@ -16,7 +16,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v3
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup-python action is using v3, which may not support Python 3.14 even when it's released. Consider updating to v5 (the latest version as of early 2025) to ensure better support for newer Python versions. This is particularly important if you intend to use Python 3.13 or any future Python versions.

Suggested change
uses: actions/setup-python@v3
uses: actions/setup-python@v5

Copilot uses AI. Check for mistakes.
Comment thread asv.conf.actions.json
// This list needs to be updated after each release of sympy. The branch to
// be checked should always be the previous release.
"branches": ["1.12", "master", "HEAD"], // for git
"branches": ["1.14", "master", "HEAD"], // for git
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that SymPy 1.14 has been released. The comment on line 30-31 indicates this should be the previous release version. If SymPy 1.14 hasn't been released yet, this will cause the benchmarks to fail when trying to check out this branch from the SymPy repository. You can verify the existence of this branch/tag at https://github.com/sympy/sympy.

Suggested change
"branches": ["1.14", "master", "HEAD"], // for git
"branches": ["1.13", "master", "HEAD"], // for git

Copilot uses AI. Check for mistakes.
@vprayag2005
Copy link
Copy Markdown
Contributor Author

I have disabled Copilot review. Actually, I don't like it since it's not that much useful. I thought It was turned it on at the org level. Now I find it in my settings, hoping that from the next PR onward it will not review.

@vprayag2005 vprayag2005 reopened this Feb 23, 2026
@oscarbenjamin
Copy link
Copy Markdown
Contributor

Might need to rebase.

@vprayag2005 vprayag2005 changed the title Update CI config: SymPy 1.14, Python 3.14 Update ASV config to SymPy 1.14 and CI to Python 3.14 Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants