Skip to content

Limit shared sparse trie payload tx execution#4164

Draft
decofe wants to merge 3 commits into
mainfrom
agent-1779453494-25518-10910
Draft

Limit shared sparse trie payload tx execution#4164
decofe wants to merge 3 commits into
mainfrom
agent-1779453494-25518-10910

Conversation

@decofe
Copy link
Copy Markdown
Member

@decofe decofe commented May 22, 2026 •
edited
Loading

Summary

  • Stop adding pool transactions in shared sparse trie payload builds after included transaction execution reaches 170ms.
  • Finish the payload immediately after that cutoff, then idle until the payload interrupt/proposal flag arrives before returning the frozen payload.
  • Add a block-build stop reason label for this cutoff.

Tests

  • cargo fmt --check
  • cargo test -p tempo-payload-builder

@decofe decofe force-pushed the agent-1779453494-25518-10910 branch from 16eacb2 to 8944edb Compare May 22, 2026 12:44
@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=100 feature-args="--builder.enable-prewarming --consensus.time-to-prepare-proposal-transactions=400ms" baseline-args="--builder.enable-prewarming --consensus.time-to-prepare-proposal-transactions=400ms"

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

❌ Benchmark failed. View logs

@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=100 feature-args="--consensus.time-to-prepare-proposal-transactions=400ms" baseline-args="--consensus.time-to-prepare-proposal-transactions=400ms"

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

✅ Benchmark complete! View job

Bench Comparison: main vs agent-1779453494-25518-10910

Configuration

  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 30000
  • Duration: 100s
  • Run pairs: 2
  • Snapshot: schelk
  • Baseline blocks: 198
  • Feature blocks: 264

Tempo Metrics

Metric Baseline Feature Delta
Avg TPS 16844.0 14853.0 -11.8%
TPS P50 16847.5 15064.1 -10.6%
TPS P90 20570.4 17102.5 -16.9%
TPS P99 35605.1 22323.5 -37.3%
Gas Throughput [Mgas/s] 820.9 723.9 -11.8%
Block Time P50 [ms] 1061.0 796.0 -25.0%
Block Time P90 [ms] 1155.0 835.0 -27.7%
Block Time P99 [ms] 1192.0 856.0 -28.2%

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 1834.6 1724.8 -6.0%
Latency P50 [ms] 452.3 320.6 -29.1%
Latency P90 [ms] 471.1 395.6 -16.0%
Latency P99 [ms] 475.3 402.9 -15.2%
Finish P50 [ms] 72.2 50.7 -29.8%
Finish P99 [ms] 87.2 63.0 -27.8%
Included Tx Exec P50 [ms] 295.4 203.2 -31.2%
Included Tx Exec P99 [ms] 331.2 212.3 -35.9%
Invalid Tx Exec P99 [ms] 0.2 0.3 50.0%
Invalid Tx Attempts P99 47.6 58.6 23.1%
Invalid Tx Skips 6769.0 12455.0 84.0%
Fill Overhead P50 [ms] 21.2 14.2 -33.0%
Fill Overhead P99 [ms] 57.6 80.0 38.9%
Fill Idle P50 [ms] 30.9 24.9 -19.4%
Fill Idle P99 [ms] 191.1 191.4 0.2%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2026.2 2024.5 -0.1%
P50 [ms] 375.4 250.6 -33.2%
P90 [ms] 431.9 282.2 -34.7%
P99 [ms] 442.1 288.9 -34.7%

Observability

@decofe decofe force-pushed the agent-1779453494-25518-10910 branch from 8944edb to 754c1e0 Compare May 22, 2026 13:46
@decofe decofe force-pushed the agent-1779453494-25518-10910 branch from 754c1e0 to 48e41de Compare May 22, 2026 13:46
@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=100 feature-args="--consensus.time-to-prepare-proposal-transactions=400ms" baseline-args="--consensus.time-to-prepare-proposal-transactions=400ms"

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

✅ Benchmark complete! View job

Bench Comparison: main vs agent-1779453494-25518-10910

Configuration

  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 30000
  • Duration: 100s
  • Run pairs: 2
  • Snapshot: schelk
  • Baseline blocks: 195
  • Feature blocks: 299

Tempo Metrics

Metric Baseline Feature Delta
Avg TPS 16470.0 12520.0 -24.0%
TPS P50 16575.2 12791.0 -22.8%
TPS P90 19846.0 14305.0 -27.9%
TPS P99 44790.4 24792.1 -44.6%
Gas Throughput [Mgas/s] 802.7 610.2 -24.0%
Block Time P50 [ms] 1091.0 707.0 -35.2%
Block Time P90 [ms] 1160.0 745.0 -35.8%
Block Time P99 [ms] 1232.0 767.0 -37.7%

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 1777.4 1657.2 -6.8%
Latency P50 [ms] 456.7 259.8 -43.1%
Latency P90 [ms] 474.5 320.9 -32.4%
Latency P99 [ms] 478.8 347.1 -27.5%
Finish P50 [ms] 77.0 39.5 -48.7%
Finish P99 [ms] 90.9 48.1 -47.1%
Included Tx Exec P50 [ms] 293.6 158.7 -45.9%
Included Tx Exec P99 [ms] 329.8 164.7 -50.1%
Invalid Tx Exec P99 [ms] 0.2 0.1 -50.0%
Invalid Tx Attempts P99 49.6 24.2 -51.2%
Invalid Tx Skips 4825.0 14676.0 204.2%
Fill Overhead P50 [ms] 22.4 11.7 -47.8%
Fill Overhead P99 [ms] 58.2 38.1 -34.5%
Fill Idle P50 [ms] 30.7 21.9 -28.7%
Fill Idle P99 [ms] 192.3 190.2 -1.1%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 1973.4 2040.6 3.4%
P50 [ms] 378.5 191.6 -49.4%
P90 [ms] 430.3 210.4 -51.1%
P99 [ms] 438.3 216.1 -50.7%

Observability

@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=100 feature-args="--consensus.time-to-prepare-proposal-transactions=400ms" baseline-args="--consensus.time-to-prepare-proposal-transactions=400ms" samply

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

✅ Benchmark complete! View job

Bench Comparison: main vs agent-1779453494-25518-10910

Configuration

  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 30000
  • Duration: 100s
  • Run pairs: 2
  • Snapshot: schelk
  • Baseline blocks: 205
  • Feature blocks: 301

Tempo Metrics

Metric Baseline Feature Delta
Avg TPS 16562.0 12777.0 -22.9%
TPS P50 16609.1 13073.9 -21.3%
TPS P90 21252.3 14830.6 -30.2%
TPS P99 27235.9 25780.2 -5.3%
Gas Throughput [Mgas/s] 807.2 622.7 -22.9%
Block Time P50 [ms] 1059.0 709.0 -33.1%
Block Time P90 [ms] 1139.0 737.0 -35.3%
Block Time P99 [ms] 1172.0 756.0 -35.5%

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 1787.3 1684.5 -5.8%
Latency P50 [ms] 450.9 258.6 -42.6%
Latency P90 [ms] 470.0 352.9 -24.9%
Latency P99 [ms] 474.2 386.1 -18.6%
Finish P50 [ms] 71.9 39.4 -45.2%
Finish P99 [ms] 88.6 48.0 -45.8%
Included Tx Exec P50 [ms] 297.7 158.7 -46.7%
Included Tx Exec P99 [ms] 328.1 165.1 -49.7%
Invalid Tx Exec P99 [ms] 0.4 0.4 0.0%
Invalid Tx Attempts P50 2.0 0.0 -100.0%
Invalid Tx Attempts P99 69.6 66.9 -3.9%
Invalid Tx Skips 8613.0 10143.0 17.8%
Fill Overhead P50 [ms] 24.4 11.5 -52.9%
Fill Overhead P99 [ms] 69.1 99.2 43.6%
Fill Idle P50 [ms] 30.0 20.7 -31.0%
Fill Idle P99 [ms] 190.7 188.5 -1.2%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2027.3 2127.2 4.9%
P50 [ms] 366.0 188.6 -48.5%
P90 [ms] 421.0 207.9 -50.6%
P99 [ms] 429.2 214.8 -50.0%

Observability

Samply Profiles

@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=100 feature-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 300ms" baseline-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 300ms"

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

⚠️ Benchmark cancelled. View logs

@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=100 feature-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 300ms" baseline-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 300ms"

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

✅ Benchmark complete! View job

Bench Comparison: main vs agent-1779453494-25518-10910

Configuration

  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 30000
  • Duration: 100s
  • Run pairs: 2
  • Snapshot: schelk
  • Baseline blocks: 320
  • Feature blocks: 372

Tempo Metrics

Metric Baseline Feature Delta
Avg TPS 16438.0 15848.0 -3.6%
TPS P50 16660.5 16152.0 -3.1%
TPS P90 23031.3 19755.6 -14.2%
TPS P99 27735.0 35101.6 26.6%
Gas Throughput [Mgas/s] 801.2 772.4 -3.6%
Block Time P50 [ms] 675.0 571.0 -15.4%
Block Time P90 [ms] 720.0 597.0 -17.1%
Block Time P99 [ms] 752.0 610.0 -18.9%

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 1750.3 1707.2 -2.5%
Latency P50 [ms] 285.0 246.3 -13.6%
Latency P90 [ms] 298.7 263.6 -11.8%
Latency P99 [ms] 303.2 266.8 -12.0%
Finish P50 [ms] 46.7 37.9 -18.8%
Finish P99 [ms] 60.7 49.4 -18.6%
Included Tx Exec P50 [ms] 187.1 157.5 -15.8%
Included Tx Exec P99 [ms] 209.6 165.8 -20.9%
Invalid Tx Exec P99 [ms] 0.3 0.4 33.3%
Invalid Tx Attempts P50 0.6 0.0 -100.0%
Invalid Tx Attempts P99 67.4 95.4 41.5%
Invalid Tx Skips 9299.0 10063.0 8.2%
Fill Overhead P50 [ms] 13.9 11.4 -18.0%
Fill Overhead P99 [ms] 50.5 67.3 33.3%
Fill Idle P50 [ms] 17.2 14.9 -13.4%
Fill Idle P99 [ms] 122.0 121.1 -0.7%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 1995.4 2009.5 0.7%
P50 [ms] 234.2 192.6 -17.8%
P90 [ms] 274.4 219.9 -19.9%
P99 [ms] 284.6 228.4 -19.7%

Observability

@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=200 feature-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 300ms" baseline-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 260ms"

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

⚠️ Benchmark cancelled. View logs

@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=200 feature-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 260ms" baseline-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 260ms"

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

✅ Benchmark complete! View job

Bench Comparison: main vs agent-1779453494-25518-10910

Configuration

  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 30000
  • Duration: 200s
  • Run pairs: 2
  • Snapshot: schelk
  • Baseline blocks: 630
  • Feature blocks: 707

Tempo Metrics

Metric Baseline Feature Delta
Avg TPS 16527.0 16222.0 -1.8%
TPS P50 16691.4 16594.2 -0.6%
TPS P90 21856.4 20500.0 -6.2%
TPS P99 27741.4 25236.3 -9.0%
Gas Throughput [Mgas/s] 805.4 790.6 -1.8%
Block Time P50 [ms] 663.0 589.0 -11.2%
Block Time P90 [ms] 708.0 618.0 -12.7%
Block Time P99 [ms] 738.0 633.0 -14.2%

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 1760.1 1712.8 -2.7%
Latency P50 [ms] 288.6 261.5 -9.4%
Latency P90 [ms] 300.9 270.4 -10.1%
Latency P99 [ms] 306.1 274.2 -10.4%
Finish P50 [ms] 50.7 42.3 -16.6%
Finish P99 [ms] 64.1 55.1 -14.0%
Included Tx Exec P50 [ms] 190.2 169.7 -10.8%
Included Tx Exec P99 [ms] 210.8 177.8 -15.7%
Invalid Tx Exec P50 [ms] 0.0 0.1 0.0%
Invalid Tx Exec P99 [ms] 0.3 0.4 33.3%
Invalid Tx Attempts P50 3.9 10.1 159.0%
Invalid Tx Attempts P99 61.5 74.2 20.7%
Invalid Tx Skips 10513.0 15037.0 43.0%
Fill Overhead P50 [ms] 16.7 20.6 23.4%
Fill Overhead P99 [ms] 59.1 67.4 14.0%
Fill Idle P50 [ms] 9.5 8.6 -9.5%
Fill Idle P99 [ms] 62.3 62.3 0.0%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2052.1 2045.7 -0.3%
P50 [ms] 241.0 210.6 -12.6%
P90 [ms] 274.0 237.8 -13.2%
P99 [ms] 284.4 245.0 -13.9%

Observability

@joshieDo
Copy link
Copy Markdown
Member

joshieDo commented May 22, 2026

derek bench mode=e2e tps=30000 duration=200 feature-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 260ms" baseline-args="--consensus.time-to-prepare-proposal-transactions=250ms --consensus.minimum-time-before-propose 260ms"

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 22, 2026 •
edited
Loading

cc @joshieDo

✅ Benchmark complete! View job

Bench Comparison: main vs agent-1779453494-25518-10910

Configuration

  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 30000
  • Duration: 200s
  • Run pairs: 2
  • Snapshot: schelk
  • Baseline blocks: 631
  • Feature blocks: 754

Tempo Metrics

Metric Baseline Feature Delta
Avg TPS 16548.0 16027.0 -3.1%
TPS P50 16752.2 16592.0 -1.0%
TPS P90 21969.8 19770.0 -10.0%
TPS P99 27140.7 25172.8 -7.3%
Gas Throughput [Mgas/s] 806.5 781.1 -3.1%
Block Time P50 [ms] 665.0 553.0 -16.8%
Block Time P90 [ms] 705.0 583.0 -17.3%
Block Time P99 [ms] 736.0 611.0 -17.0%

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 1766.1 1666.0 -5.7%
Latency P50 [ms] 289.0 252.1 -12.8%
Latency P90 [ms] 300.6 263.3 -12.4%
Latency P99 [ms] 305.8 268.9 -12.1%
Finish P50 [ms] 50.5 39.6 -21.6%
Finish P99 [ms] 64.2 51.9 -19.2%
Included Tx Exec P50 [ms] 190.6 159.4 -16.4%
Included Tx Exec P99 [ms] 210.8 168.5 -20.1%
Invalid Tx Exec P50 [ms] 0.0 0.1 0.0%
Invalid Tx Exec P99 [ms] 0.3 0.4 33.3%
Invalid Tx Attempts P50 3.7 15.7 324.3%
Invalid Tx Attempts P99 66.8 79.9 19.6%
Invalid Tx Skips 10448.0 25531.0 144.4%
Fill Overhead P50 [ms] 16.7 24.7 47.9%
Fill Overhead P99 [ms] 60.2 72.0 19.6%
Fill Idle P50 [ms] 9.5 8.5 -10.5%
Fill Idle P99 [ms] 62.3 63.1 1.3%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2058.2 2052.1 -0.3%
P50 [ms] 241.8 196.7 -18.7%
P90 [ms] 274.4 224.9 -18.0%
P99 [ms] 282.8 231.9 -18.0%

Observability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xKitsune 0xKitsune Awaiting requested review from 0xKitsune 0xKitsune will be requested when the pull request is marked ready for review 0xKitsune is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@decofe @joshieDo