fix(tip20): address rewards review comments#4169
Open
decofe wants to merge 1 commit into
Open
Conversation
Contributor
📊 Tempo Precompiles CoverageprecompilesCoverage: 5642/8434 lines (66.90%) File details
contractsCoverage: 1/48 lines (2.08%) File details
Total: 5643/8482 lines (66.53%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments on #4161.\n\nChanges:\n- Rename packed balance storage type to TIP20UserState.\n- Replace boolean opted-in supply updater with explicit increase/decrease helpers.\n- Simplify reward updates to avoid cached storage-read arguments.\n- Rename RewardFlag constructor to from_delegate and use old_flag/new_flag naming.\n- Checkpoint reward_per_token when opting into T6 rewards.\n\nValidation:\n- cargo check -p tempo-precompiles\n- cargo test -p tempo-precompiles tip20::rewards