Made it compatible with the new composition api #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exports the functions loadScript and unloadScript, so they can be used directly by importing them. The previous behavior of using this.loadScript still works.
|
The reason for exporting the functions btw, is that "this" is not available inside the setup function in components. |
|
Hi. Is there an update on getting this merged available? |
tserkov
requested changes
Apr 27, 2021
There was a problem hiding this comment.
Hey @Bjornar97! Sorry for incredible delay! I've made a few minor requests to the code, and after they're made I'll smash that merge button.
Thanks for taking care of Composition API support!
|
Lgtm, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports the functions loadScript and unloadScript, so they can be used directly by importing them. The previous behavior of using this.loadScript still works.
Feel free to make any changes you see fit.