fix(ssr): apply alias to resolvable dependencies during dev#15602
Merged
bluwy merged 7 commits intoMar 12, 2024
Conversation
|
|
hi-ogawa
commented
Jan 16, 2024
Comment on lines
+4
to
+11
| test.runIf(isServe)('dev', async () => { | ||
| const mod = await viteServer.ssrLoadModule('/src/main.js') | ||
| expect(mod.default).toEqual({ | ||
| dep: 'ok', | ||
| nonDep: 'ok', | ||
| builtin: 'ok', | ||
| }) | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
Previous behavior was that:
{
dep: 'original',
nonDep: 'ok',
builtin: undefined,
}which is inconsistent with build mode.
patak-cat
approved these changes
Jan 16, 2024
bluwy
approved these changes
Mar 12, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found this dev/build inconsistency while investigating the issue #15503 (comment),
but the issue itself seems to be more complicated and currently it's waiting for proper reproduction.(EDIT: I think this is the only vite side issue, so we can close it if this PR is merged.)Given that there is a big warning in https://vitejs.dev/guide/ssr.html#ssr-externals, I suppose relying on
resolve.aliasmight not be recommended in general. However, considering this is one source of dev/build inconsistency for non-external modules, so I thought this is worth making it consistent. Please let me know if this fix is appropriate here.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).