fix(core): 🐛 notificationpopover is design is completed properly #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notificationpopover has been fixed Ref: #373
techoneel
reviewed
Sep 21, 2024
…previouly given the coreicon more_horiz to clear_all which was there previouly was been required is solved Ref: #373
…o WRPD-bugfix-373
3 tasks
remove the sx property Ref: #373
There was a problem hiding this comment.
Pull Request Overview
This PR fixes design issues in the NotificationPopOver component, addressing layout and styling discrepancies as outlined in the ticket.
- Updated flex and alignment style classes to achieve the desired layout.
- Adjusted typography margins and divider styling.
- Modified the minWidth property to improve consistency with design specifications.
Comments suppressed due to low confidence (2)
package/components/utils/NotificationPopOver.js:16
- Ensure that replacing the previous flex classes with the new CoreClasses.DISPLAY.FLEX and ALIGNMENT.ALIGN_ITEMS_CENTER achieves the intended layout across all devices.
styleClasses={[CoreClasses.DISPLAY.FLEX, CoreClasses.ALIGNMENT.JUSTIFY_CONTENT_SPACE_BETWEEN, CoreClasses.ALIGNMENT.ALIGN_ITEMS_CENTER]}
package/components/utils/NotificationPopOver.js:31
- Replacing the sx prop with minWidth set as a number removes explicit unit specification; please verify that the component treats 350 as '350px' or adjust as necessary.
minWidth={350}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #373
Screenshots (if applicable)