Skip to content

/ uk.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation: First steps > Function expression and arrows #48

Merged
merged 10 commits into from Oct 23, 2019
Merged

Translation: First steps > Function expression and arrows #48

merged 10 commits into from Oct 23, 2019

Conversation

@Tuoris
Copy link
Contributor

@Tuoris Tuoris commented Oct 23, 2019

Note: given the fact that some words and phrases are yet missing from glossary,
I use following translations (source - MDN 🇺🇦) for them:

  • Function Declaration -> Оголошення Функції, left both words capitalized for better clarity and readability
  • Function Expression -> Функціональний Вираз, left both words capitalized for the same reason
  • expression -> вираз
  • strict mode -> суворий режим
  • callback -> колбек/функція зворотного виклику, source - Wiki 🇺🇦

Bonus 😆 :

  • John -> Микола - most common ukrainian first name according to Internet
Tuoris added 9 commits Oct 7, 2019
@Tuoris
Translate introduction
02f5840
@Tuoris
Translate "Callback functions"
fd1586e
@Tuoris
Translate "Function Expression vs Function Declaration"
8237aee
@Tuoris
Translate "Arrow functions"
2deba0f
@Tuoris
Fix typos
fa545a8
@Tuoris
Translate summary
a659f19
@Tuoris
Translate programming assignment
14bf239
@Tuoris
Translate assignment solution
497d1c4
@Tuoris
Fix minor typos in "Function expressions and arrows"
953d199
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-uk Oct 23, 2019
@tarasyyyk
Copy link
Collaborator

@tarasyyyk tarasyyyk commented Oct 23, 2019

  • expression was agreed to translate as вираз. Added to Glossary. Thanks.

  • strict mode - not agreed yet: #39

  • callback - not agreed yet. Need to create issue and discuss. For me, the both variant are good.

  • John - we translate as Іван. Микола will be used for Michael.
@Tuoris
Copy link
Contributor Author

@Tuoris Tuoris commented Oct 23, 2019 •
edited

Good point, @tarasyyyk !

  • callback - I feel that колбек and функція зворотного виклику are synonyms and both can be used. Please create an issue if needed (I personally think it's not)
  • strict mode - most voted translation is used (few weeks left)
  • John - sure, I'll change Микола -> Іван (yet russian version uses Вася) )

Edit: fix typo
@Tuoris
Replace "Микола" -> "Іван"
Loading status checks…
b932575
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Oct 23, 2019 •
edited

CLA assistant check
All committers have signed the CLA.
@tarasyyyk
tarasyyyk approved these changes Oct 23, 2019
View changes
Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Great job! There are a lot of text and no any major mistakes. This is the first such pull request!
Some translation even better that english source text (I mean Error => ReferenceError).
@tarasyyyk tarasyyyk merged commit 66b0a58 into javascript-tutorial:master Oct 23, 2019
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@iliakan iliakan mentioned this pull request Oct 23, 2019
Open
28 of 167 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarasyyyk tarasyyyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Tuoris @tarasyyyk @CLAassistant @javascript-translate-bot
You can’t perform that action at this time.