Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Aug 7, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and a team August 7, 2020 15:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #658 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #658   +/-   ##
=========================================
  Coverage     81.49%   81.49%           
  Complexity     1226     1226           
=========================================
  Files            77       77           
  Lines          6220     6220           
  Branches        691      691           
=========================================
  Hits           5069     5069           
  Misses          792      792           
  Partials        359      359           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 319b982...050efbd. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 6488cd1 into googleapis:master Aug 7, 2020
@pmakani pmakani deleted the query_external_sheets_perm branch August 10, 2020 09:55
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants