Skip to content

docs: clarify the types of Message parameters #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2021
Merged

docs: clarify the types of Message parameters #486

merged 2 commits into from
Sep 2, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Sep 2, 2021

Closes #485.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from anguillanneuf September 2, 2021 10:59
@plamut plamut requested review from a team as code owners September 2, 2021 10:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 2, 2021
@plamut
Copy link
Contributor Author

plamut commented Sep 2, 2021

@jceresini If you have time, please have a look at this and let me know if the changed docs are now more clear to you, the library user. Thanks!

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@jceresini
Copy link

This definitely helps, and makes sense. Thanks.

@tseaver tseaver merged commit 633e91b into googleapis:main Sep 2, 2021
@plamut plamut deleted the iss-485 branch September 2, 2021 14:16
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 6, 2021
@release-please
chore: release 2.8.0 (#491)
9e439e5 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.8.0](https://www.github.com/googleapis/python-pubsub/compare/v2.7.1...v2.8.0) (2021-09-02)


### Features

* closed subscriber as context manager raises ([#488](https://www.github.com/googleapis/python-pubsub/issues/488)) ([a05a3f2](https://www.github.com/googleapis/python-pubsub/commit/a05a3f250cf8567ffe0d2eb3ecc45856a2bcd07c))


### Documentation

* clarify the types of Message parameters ([#486](https://www.github.com/googleapis/python-pubsub/issues/486)) ([633e91b](https://www.github.com/googleapis/python-pubsub/commit/633e91bbfc0a8f4f484089acff6812b754f40c75))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when manually instantiaing message.Message in unit tests
4 participants
@plamut @jceresini @tseaver @yoshi-kokoro