| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Index maintenance function for BRIN doesn't check RecoveryInProgress() |
| Date: | 2018-06-14 17:20:54 |
| Message-ID: | 20180614172054.nokutoeix3jfuqaf@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Jun-14, Michael Paquier wrote:
> On Thu, Jun 14, 2018 at 02:06:57AM +0900, Masahiko Sawada wrote:
> > On Thu, Jun 14, 2018 at 12:04 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> >> On 13 June 2018 at 15:51, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> >>> I guess you could go either way ... we're just changing one unhelpful
> >>> error with a better one: there is no change in behavior. I would
> >>> backpatch this, myself, and avoid the code divergence.
> >>
> >> WAL control functions all say the same thing, so we can do that here also.
> >
> > +1
>
> +1 for a back-patch to v10. The new error message brings clarity in my
> opinion.
Pushed, backpatched to 9.5. Thanks!
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-06-14 17:34:29 | Re: PostgreSQL vs SQL Standard |
| Previous Message | Andres Freund | 2018-06-14 17:10:29 | Re: Shared access methods? |