feat(ble): Enable BLE for ESP32-P4 through esp-hosted #11804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 13m 14s ⏱️ Results for commit 99c7ceb. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
me-no-dev
reviewed
Sep 6, 2025
0c47190 to
f794498
Compare
P-R-O-C-H-Y
approved these changes
Sep 10, 2025
|
@lucasssvaz you can enable the examples on P4 now |
There was a problem hiding this comment.
Pull Request Overview
This PR enables BLE functionality on ESP32-P4 through the esp-hosted transport layer. It consolidates ESP-Hosted related functions into reusable components for both Wi-Fi and BLE, and extends BLE library support to chips without native BLE hardware.
- Moved ESP-Hosted initialization code from WiFi-specific to generic implementation
- Extended BLE library compilation guards to support hosted BLE via
CONFIG_ESP_HOSTED_ENABLE_BT_NIMBLE - Added hosted BLE transport management functions with proper lifecycle handling
Reviewed Changes
Copilot reviewed 71 out of 71 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libraries/WiFi/src/WiFiGeneric.cpp | Refactored ESP-Hosted functions to use generic hosted API |
| libraries/BLE/src/*.h | Extended compilation guards to support hosted BLE |
| libraries/BLE/src/*.cpp | Extended compilation guards to support hosted BLE |
| cores/esp32/esp32-hal-hosted.* | New generic ESP-Hosted management API |
| CMakeLists.txt | Added hosted HAL source file to build |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
177
to
189
| int tx_power = 0; | ||
| #if SOC_BLE_SUPPORTED | ||
| switch (advertisedTxPower) { | ||
| case ESP_PWR_LVL_N12: // 12dbm | ||
| tx_power = -12; | ||
| break; | ||
| case ESP_PWR_LVL_N9: // -9dbm | ||
| tx_power = -9; | ||
| break; | ||
| case ESP_PWR_LVL_N6: // -6dbm | ||
| tx_power = -6; | ||
| break; | ||
| case ESP_PWR_LVL_N3: // -3dbm | ||
| tx_power = -3; | ||
| break; | ||
| case ESP_PWR_LVL_N0: // 0dbm | ||
| tx_power = 0; | ||
| break; | ||
| case ESP_PWR_LVL_P3: // +3dbm | ||
| tx_power = +3; | ||
| break; | ||
| case ESP_PWR_LVL_P6: // +6dbm | ||
| tx_power = +6; | ||
| break; | ||
| case ESP_PWR_LVL_P9: // +9dbm | ||
| tx_power = +9; | ||
| break; | ||
| default: tx_power = 0; | ||
| case ESP_PWR_LVL_N12: tx_power = -12; break; | ||
| case ESP_PWR_LVL_N9: tx_power = -9; break; | ||
| case ESP_PWR_LVL_N6: tx_power = -6; break; | ||
| case ESP_PWR_LVL_N3: tx_power = -3; break; | ||
| case ESP_PWR_LVL_N0: tx_power = 0; break; | ||
| case ESP_PWR_LVL_P3: tx_power = +3; break; | ||
| case ESP_PWR_LVL_P6: tx_power = +6; break; | ||
| case ESP_PWR_LVL_P9: tx_power = +9; break; | ||
| default: tx_power = 0; break; | ||
| } |
There was a problem hiding this comment.
Variable tx_power is initialized to 0 on line 177, then potentially reassigned in the switch statement. However, the default case also sets it to 0, making the initial assignment redundant. Consider removing the initial assignment or moving the declaration inside the #if SOC_BLE_SUPPORTED block.
Copilot uses AI. Check for mistakes.
me-no-dev
approved these changes
Sep 11, 2025
|
@SuGlider PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added support for BLE on ESP32-P4 via esp-hosted. Also moved esp-hosted related functions to a generic file that can be used by both Wi-Fi and BLE.
Requires espressif/esp32-arduino-lib-builder#318
Test Scenarios
Tested locally
Related links
Closes #11788
#10278